Commit c34c78df authored by Yunfeng Ye's avatar Yunfeng Ye Committed by Paul Moore
Browse files

audit: remove redundant condition check in kauditd_thread() 



Warning is found by the code analysis tool:
  "the condition 'if(ac && rc < 0)' is redundant: ac"

The @ac variable has been checked before. It can't be a null pointer
here, so remove the redundant condition check.

Signed-off-by: default avatarYunfeng Ye <yeyunfeng@huawei.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 245d7369

kernel/audit.c

+2 −2
Original line number Diff line number Diff line
@@ -830,7 +830,7 @@ static int kauditd_thread(void *dummy) 
		rc = kauditd_send_queue(sk, portid,

					&audit_hold_queue, UNICAST_RETRIES,

					NULL, kauditd_rehold_skb);

		if (ac && rc < 0) {

		if (rc < 0) {

			sk = NULL;

			auditd_reset(ac);

			goto main_queue;
@@ -840,7 +840,7 @@ static int kauditd_thread(void *dummy) 
		rc = kauditd_send_queue(sk, portid,

					&audit_retry_queue, UNICAST_RETRIES,

					NULL, kauditd_hold_skb);

		if (ac && rc < 0) {

		if (rc < 0) {

			sk = NULL;

			auditd_reset(ac);

			goto main_queue;