Commit c33ef43a authored by Frederic Weisbecker's avatar Frederic Weisbecker Committed by Paul E. McKenney
Browse files

rcu/context-tracking: Remove unused and/or unecessary middle functions 



Some eqs functions are now only used internally by context tracking, so
their public declarations can be removed.

Also middle functions such as rcu_user_*() and rcu_idle_*()
which now directly call to rcu_eqs_enter() and rcu_eqs_exit() can be
wiped out as well.

Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Cc: Uladzislau Rezki <uladzislau.rezki@sony.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: Yu Liao <liaoyu15@huawei.com>
Cc: Phil Auld <pauld@redhat.com>
Cc: Paul Gortmaker<paul.gortmaker@windriver.com>
Cc: Alex Belits <abelits@marvell.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Reviewed-by: default avatarNicolas Saenz Julienne <nsaenzju@redhat.com>
Tested-by: default avatarNicolas Saenz Julienne <nsaenzju@redhat.com>
parent 17211455

Documentation/RCU/stallwarn.rst

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ warnings: 
	which will include additional debugging information.



-	A low-level kernel issue that either fails to invoke one of the

	variants of rcu_user_enter(), rcu_user_exit(), ct_idle_enter(),

	variants of rcu_eqs_enter(true), rcu_eqs_exit(true), ct_idle_enter(),

	ct_idle_exit(), ct_irq_enter(), or ct_irq_exit() on the one

	hand, or that invokes one of them too many times on the other.

	Historically, the most frequent issue has been an omission

include/linux/hardirq.h

+0 −8
Original line number Diff line number Diff line
@@ -92,14 +92,6 @@ void irq_exit_rcu(void); 
#define arch_nmi_exit()		do { } while (0)

#endif



#ifdef CONFIG_TINY_RCU

static inline void rcu_nmi_enter(void) { }

static inline void rcu_nmi_exit(void) { }

#else

extern void rcu_nmi_enter(void);

extern void rcu_nmi_exit(void);

#endif



/*

 * NMI vs Tracing

 * --------------

include/linux/rcupdate.h

+0 −8
Original line number Diff line number Diff line
@@ -104,14 +104,6 @@ static inline void rcu_sysrq_start(void) { } 
static inline void rcu_sysrq_end(void) { }

#endif /* #else #ifdef CONFIG_RCU_STALL_COMMON */



#ifdef CONFIG_NO_HZ_FULL

void rcu_user_enter(void);

void rcu_user_exit(void);

#else

static inline void rcu_user_enter(void) { }

static inline void rcu_user_exit(void) { }

#endif /* CONFIG_NO_HZ_FULL */



#if defined(CONFIG_NO_HZ_FULL) && (!defined(CONFIG_GENERIC_ENTRY) || !defined(CONFIG_KVM_XFER_TO_GUEST_WORK))

void rcu_irq_work_resched(void);

#else

include/linux/rcutiny.h

+0 −2
Original line number Diff line number Diff line
@@ -76,8 +76,6 @@ static inline int rcu_needs_cpu(void) 
static inline void rcu_virt_note_context_switch(int cpu) { }

static inline void rcu_cpu_stall_reset(void) { }

static inline int rcu_jiffies_till_stall_check(void) { return 21 * HZ; }

static inline void rcu_idle_enter(void) { }

static inline void rcu_idle_exit(void) { }

static inline void rcu_irq_exit_check_preempt(void) { }

#define rcu_is_idle_cpu(cpu) \

	(is_idle_task(current) && !in_nmi() && !in_hardirq() && !in_serving_softirq())

include/linux/rcutree.h

+0 −2
Original line number Diff line number Diff line
@@ -45,8 +45,6 @@ unsigned long start_poll_synchronize_rcu(void); 
bool poll_state_synchronize_rcu(unsigned long oldstate);

void cond_synchronize_rcu(unsigned long oldstate);



void rcu_idle_enter(void);

void rcu_idle_exit(void);

bool rcu_is_idle_cpu(int cpu);



#ifdef CONFIG_PROVE_RCU