Commit c3336b8a authored by Dan Carpenter's avatar Dan Carpenter Committed by Alexandre Belloni
Browse files

rtc: rv3032: fix error handling in rv3032_clkout_set_rate() 



Do not call rv3032_exit_eerd() if the enter function fails but don't
forget to call the exit when the enter succeeds.

Fixes: 2eeaa532 ("rtc: rv3032: Add a driver for Microcrystal RV-3032")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211012101028.GT2083@kadam
parent 24d23181

drivers/rtc/rtc-rv3032.c

+2 −2
Original line number Diff line number Diff line
@@ -617,11 +617,11 @@ static int rv3032_clkout_set_rate(struct clk_hw *hw, unsigned long rate, 


	ret = rv3032_enter_eerd(rv3032, &eerd);

	if (ret)

		goto exit_eerd;

		return ret;



	ret = regmap_write(rv3032->regmap, RV3032_CLKOUT1, hfd & 0xff);

	if (ret)

		return ret;

		goto exit_eerd;



	ret = regmap_write(rv3032->regmap, RV3032_CLKOUT2, RV3032_CLKOUT2_OS |

			    FIELD_PREP(RV3032_CLKOUT2_HFD_MSK, hfd >> 8));