Unverified Commit c30c8f9d authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Lock substream before snd_pcm_stop() 



snd_pcm_stop() shall be called with stream lock held to prevent any
races between nonatomic streaming operations.

Fixes: 2f1f570c ("ASoC: Intel: avs: Coredump and recovery flow")
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221116115550.1100398-2-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bce3e9f0

sound/soc/intel/avs/ipc.c

+3 −0
Original line number Diff line number Diff line
@@ -123,7 +123,10 @@ static void avs_dsp_recovery(struct avs_dev *adev) 
				if (!substream || !substream->runtime)

					continue;



				/* No need for _irq() as we are in nonatomic context. */

				snd_pcm_stream_lock(substream);

				snd_pcm_stop(substream, SNDRV_PCM_STATE_DISCONNECTED);

				snd_pcm_stream_unlock(substream);

			}

		}

	}