Commit c2fbcc94 authored Aug 31, 2021 by Karen Sornek Committed by Tony Nguyen Nov 30, 2021

iavf: Refactor string format to avoid static analysis warnings



Change format to match variable type that is used in string.

Use %u format for unsigned variable and %d format for signed variable
to remove static analysis warnings.

Signed-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>
Signed-off-by: Karen Sornek <karen.sornek@intel.com>
Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

parent fbe66f57

drivers/net/ethernet/intel/iavf/iavf_main.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -463,14 +463,14 @@ iavf_request_traffic_irqs(struct iavf_adapter adapter, char basename)

		if (q_vector->tx.ring && q_vector->rx.ring) {
		snprintf(q_vector->name, sizeof(q_vector->name),
		"iavf-%s-TxRx-%d", basename, rx_int_idx++);
		"iavf-%s-TxRx-%u", basename, rx_int_idx++);
		tx_int_idx++;
		} else if (q_vector->rx.ring) {
		snprintf(q_vector->name, sizeof(q_vector->name),
		"iavf-%s-rx-%d", basename, rx_int_idx++);
		"iavf-%s-rx-%u", basename, rx_int_idx++);
		} else if (q_vector->tx.ring) {
		snprintf(q_vector->name, sizeof(q_vector->name),
		"iavf-%s-tx-%d", basename, tx_int_idx++);
		"iavf-%s-tx-%u", basename, tx_int_idx++);
		} else {
		/* skip this unused q_vector */
		continue;

drivers/net/ethernet/intel/iavf/iavf_virtchnl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1025,7 +1025,7 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)
		} else if (link_speed_mbps == SPEED_UNKNOWN) {
		snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%s", "Unknown Mbps");
		} else {
		snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%u %s",
		snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
		link_speed_mbps, "Mbps");
		}