Commit c2f2924b authored by Wang Yufen's avatar Wang Yufen Committed by Kalle Valo
Browse files

wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware() 



Fix to return a negative error code instead of 0 when
brcmf_chip_set_active() fails. In addition, change the return
value for brcmf_pcie_exit_download_state() to keep consistent.

Fixes: d380ebc9 ("brcmfmac: rename chip download functions")
Signed-off-by: default avatarWang Yufen <wangyufen@huawei.com>
Reviewed-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1669959342-27144-1-git-send-email-wangyufen@huawei.com
parent 7de16123

drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

+1 −1
Original line number Diff line number Diff line
@@ -736,7 +736,7 @@ static int brcmf_pcie_exit_download_state(struct brcmf_pciedev_info *devinfo, 
	}



	if (!brcmf_chip_set_active(devinfo->ci, resetintr))

		return -EINVAL;

		return -EIO;

	return 0;

}

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

+1 −0
Original line number Diff line number Diff line
@@ -3412,6 +3412,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus, 
	/* Take arm out of reset */

	if (!brcmf_chip_set_active(bus->ci, rstvec)) {

		brcmf_err("error getting out of ARM core reset\n");

		bcmerror = -EIO;

		goto err;

	}