Unverified Commit c2e2d89a authored Mar 05, 2024 by openeuler-ci-bot Committed by Gitee Mar 05, 2024

!4851 cachefiles: fix memory leak in cachefiles_add_cache()

Merge Pull Request from: @ci-robot 
 
PR sync from: Baokun Li <libaokun1@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/6HJSODMS3JCTT6Z7MEKTONV37LJEBTY6/ 
 
https://gitee.com/openeuler/kernel/issues/I955OO 
 
Link:https://gitee.com/openeuler/kernel/pulls/4851

 

Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Zheng Zengkai <zhengzengkai@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>

parents 81cc23e7 e5a6b3fe

fs/cachefiles/cache.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -168,6 +168,8 @@ int cachefiles_add_cache(struct cachefiles_cache *cache)
		dput(root);
		error_open_root:
		cachefiles_end_secure(cache, saved_cred);
		put_cred(cache->cache_cred);
		cache->cache_cred = NULL;
		error_getsec:
		fscache_relinquish_cache(cache_cookie);
		cache->cache = NULL;

fs/cachefiles/daemon.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -805,6 +805,7 @@ static void cachefiles_daemon_unbind(struct cachefiles_cache *cache)
		cachefiles_put_directory(cache->graveyard);
		cachefiles_put_directory(cache->store);
		mntput(cache->mnt);
		put_cred(cache->cache_cred);

		kfree(cache->rootdirname);
		kfree(cache->secctx);