Commit c2e1cfef authored by Hangyu Hua's avatar Hangyu Hua Committed by Jakub Kicinski
Browse files

net: sched: fix possible refcount leak in tc_new_tfilter() 



tfilter_put need to be called to put the refount got by tp->ops->get to
avoid possible refcount leak when chain->tmplt_ops != NULL and
chain->tmplt_ops != tp->ops.

Fixes: 7d5509fa ("net: sched: extend proto ops with 'put' callback")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Reviewed-by: default avatarVlad Buslov <vladbu@nvidia.com>
Link: https://lore.kernel.org/r/20220921092734.31700-1-hbh25y@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 878e2405

net/sched/cls_api.c

+1 −0
Original line number Diff line number Diff line
@@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n, 
	}



	if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {

		tfilter_put(tp, fh);

		NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");

		err = -EINVAL;

		goto errout;