Commit c2ab7cfe authored by Peiyang Wang's avatar Peiyang Wang Committed by Hao Chen
Browse files

net: hns3: add \n at the end when print msg 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9NZTZ


CVE: NA

----------------------------------------------------------------------

To make the print message more clearly, add \n at the and of message if
it is missing currently.

Fixes: 4c8dab1c ("net: hns3: reconstruct function hns3_self_test")

Signed-off-by: default avatarPeiyang Wang <wangpeiyang1@huawei.com>
parent 21a2659e

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+1 −1
Original line number Diff line number Diff line
@@ -2688,7 +2688,7 @@ static int hns3_nic_set_features(struct net_device *netdev, 
	if ((netdev->features & NETIF_F_HW_TC) > (features & NETIF_F_HW_TC) &&

	    h->ae_algo->ops->cls_flower_active(h)) {

		netdev_err(netdev,

			   "there are offloaded TC filters active, cannot disable HW TC offload");

			   "there are offloaded TC filters active, cannot disable HW TC offload\n");

		return -EINVAL;

	}

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+4 −4
Original line number Diff line number Diff line
@@ -436,7 +436,7 @@ static void hns3_self_test(struct net_device *ndev, 
		data[i] = HNS3_NIC_LB_TEST_UNEXECUTED;



	if (hns3_nic_resetting(ndev)) {

		netdev_err(ndev, "dev resetting!");

		netdev_err(ndev, "dev resetting!\n");

		goto failure;

	}
@@ -868,7 +868,7 @@ static int hns3_get_link_ksettings(struct net_device *netdev, 
		break;

	default:



		netdev_warn(netdev, "Unknown media type");

		netdev_warn(netdev, "Unknown media type\n");

		return 0;

	}
@@ -916,7 +916,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev, 
	if (cmd->base.duplex == DUPLEX_HALF &&

	    media_type != HNAE3_MEDIA_TYPE_COPPER) {

		netdev_err(netdev,

			   "only copper port supports half duplex!");

			   "only copper port supports half duplex!\n");

		return -EINVAL;

	}
@@ -1377,7 +1377,7 @@ static int hns3_nway_reset(struct net_device *netdev) 
		return 0;



	if (hns3_nic_resetting(netdev)) {

		netdev_err(netdev, "dev resetting!");

		netdev_err(netdev, "dev resetting!\n");

		return -EBUSY;

	}

drivers/net/ethernet/hisilicon/hns3/hns3_ext.c

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ static int nic_invoke_pri_ops(struct net_device *ndev, int opcode, 
		return -ENODEV;



	if ((!data && length) || (data && !length)) {

		netdev_err(ndev, "failed to check data and length");

		netdev_err(ndev, "failed to check data and length\n");

		return -EINVAL;

	}

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ext.c

+3 −3
Original line number Diff line number Diff line
@@ -1072,7 +1072,7 @@ static int hclge_check_phy_opt_param(struct hclge_dev *hdev, void *data, 
		return -EINVAL;



	if (mac->media_type != HNAE3_MEDIA_TYPE_COPPER) {

		dev_err(&hdev->pdev->dev, "this is not a copper port");

		dev_err(&hdev->pdev->dev, "this is not a copper port\n");

		return -EOPNOTSUPP;

	}
@@ -1080,12 +1080,12 @@ static int hclge_check_phy_opt_param(struct hclge_dev *hdev, void *data, 
		return 0;



	if (!mac->phydev) {

		dev_err(&hdev->pdev->dev, "this net device has no phy");

		dev_err(&hdev->pdev->dev, "this net device has no phy\n");

		return -EINVAL;

	}



	if (!mac->mdio_bus) {

		dev_err(&hdev->pdev->dev, "this net device has no mdio bus");

		dev_err(&hdev->pdev->dev, "this net device has no mdio bus\n");

		return -EINVAL;

	}

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −1
Original line number Diff line number Diff line
@@ -12085,7 +12085,7 @@ static int hclge_pci_init(struct hclge_dev *hdev) 
		ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));

		if (ret) {

			dev_err(&pdev->dev,

				"can't set consistent PCI DMA");

				"can't set consistent PCI DMA\n");

			goto err_disable_device;

		}

		dev_warn(&pdev->dev, "set DMA mask to 32 bits\n");