Commit c272dabf authored by Xu Yang's avatar Xu Yang Committed by Greg Kroah-Hartman
Browse files

usb: host: ehci-sched: try to turn on io watchdog as long as periodic_count > 0 



If initially isoc_count = 0, periodic_count > 0 and the io watchdog is
not started (e.g. just timed out), then the io watchdog may not run after
submitting isoc urbs and enable_periodic(). The isoc urbs may not complete
forever if the controller had already stopped periodic schedule.

This will try to call turn_on_io_watchdog() for each enable_periodic() to
ensure the io watchdog functions properly.

Signed-off-by: default avatarXu Yang <xu.yang_2@nxp.com>
Reviewed-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20230809065327.952368-1-xu.yang_2@nxp.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3ddde5aa

drivers/usb/host/ehci-sched.c

+2 −1
Original line number Diff line number Diff line
@@ -490,13 +490,14 @@ static int tt_no_collision( 
static void enable_periodic(struct ehci_hcd *ehci)

{

	if (ehci->periodic_count++)

		return;

		goto out;



	/* Stop waiting to turn off the periodic schedule */

	ehci->enabled_hrtimer_events &= ~BIT(EHCI_HRTIMER_DISABLE_PERIODIC);



	/* Don't start the schedule until PSS is 0 */

	ehci_poll_PSS(ehci);

out:

	turn_on_io_watchdog(ehci);

}