Commit c24dbf3d authored by Danielle Ratson's avatar Danielle Ratson Committed by David S. Miller
Browse files

selftests: mlxsw: Remove deprecated test cases 



After adding the previous patches, the constraint that all the router
interface MAC addresses have the same prefix is no longer relevant.

Remove the test cases that validated that this constraint is honored.

Signed-off-by: default avatarDanielle Ratson <danieller@nvidia.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 20d446db

tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh

+0 −90
Original line number Diff line number Diff line
@@ -10,9 +10,7 @@ 
lib_dir=$(dirname $0)/../../../net/forwarding



ALL_TESTS="

	rif_set_addr_test

	rif_vrf_set_addr_test

	rif_inherit_bridge_addr_test

	rif_non_inherit_bridge_addr_test

	vlan_interface_deletion_test

	bridge_deletion_test
@@ -60,55 +58,6 @@ cleanup() 
	ip link set dev $swp1 down

}



rif_set_addr_test()

{

	local swp1_mac=$(mac_get $swp1)

	local swp2_mac=$(mac_get $swp2)



	RET=0



	# $swp1 and $swp2 likely got their IPv6 local addresses already, but

	# here we need to test the transition to RIF.

	ip addr flush dev $swp1

	ip addr flush dev $swp2

	sleep .1



	ip addr add dev $swp1 192.0.2.1/28

	check_err $?



	ip link set dev $swp1 addr 00:11:22:33:44:55

	check_err $?



	# IP address enablement should be rejected if the MAC address prefix

	# doesn't match other RIFs.

	ip addr add dev $swp2 192.0.2.2/28 &>/dev/null

	check_fail $? "IP address addition passed for a device with a wrong MAC"

	ip addr add dev $swp2 192.0.2.2/28 2>&1 >/dev/null \

	    | grep -q mlxsw_spectrum

	check_err $? "no extack for IP address addition"



	ip link set dev $swp2 addr 00:11:22:33:44:66

	check_err $?

	ip addr add dev $swp2 192.0.2.2/28 &>/dev/null

	check_err $?



	# Change of MAC address of a RIF should be forbidden if the new MAC

	# doesn't share the prefix with other MAC addresses.

	ip link set dev $swp2 addr 00:11:22:33:00:66 &>/dev/null

	check_fail $? "change of MAC address passed for a wrong MAC"

	ip link set dev $swp2 addr 00:11:22:33:00:66 2>&1 >/dev/null \

	    | grep -q mlxsw_spectrum

	check_err $? "no extack for MAC address change"



	log_test "RIF - bad MAC change"



	ip addr del dev $swp2 192.0.2.2/28

	ip addr del dev $swp1 192.0.2.1/28



	ip link set dev $swp2 addr $swp2_mac

	ip link set dev $swp1 addr $swp1_mac

}



rif_vrf_set_addr_test()

{

	# Test that it is possible to set an IP address on a VRF upper despite
@@ -128,45 +77,6 @@ rif_vrf_set_addr_test() 
	ip link del dev vrf-test

}



rif_inherit_bridge_addr_test()

{

	RET=0



	# Create first RIF

	ip addr add dev $swp1 192.0.2.1/28

	check_err $?



	# Create a FID RIF

	ip link add name br1 up type bridge vlan_filtering 0

	ip link set dev $swp2 master br1

	ip addr add dev br1 192.0.2.17/28

	check_err $?



	# Prepare a device with a low MAC address

	ip link add name d up type dummy

	ip link set dev d addr 00:11:22:33:44:55



	# Attach the device to br1. That prompts bridge address change, which

	# should be vetoed, thus preventing the attachment.

	ip link set dev d master br1 &>/dev/null

	check_fail $? "Device with low MAC was permitted to attach a bridge with RIF"

	ip link set dev d master br1 2>&1 >/dev/null \

	    | grep -q mlxsw_spectrum

	check_err $? "no extack for bridge attach rejection"



	ip link set dev $swp2 addr 00:11:22:33:44:55 &>/dev/null

	check_fail $? "Changing swp2's MAC address permitted"

	ip link set dev $swp2 addr 00:11:22:33:44:55 2>&1 >/dev/null \

	    | grep -q mlxsw_spectrum

	check_err $? "no extack for bridge port MAC address change rejection"



	log_test "RIF - attach port with bad MAC to bridge"



	ip link del dev d

	ip link del dev br1

	ip addr del dev $swp1 192.0.2.1/28

}



rif_non_inherit_bridge_addr_test()

{

	local swp2_mac=$(mac_get $swp2)