Commit c24aa7b1 authored by Kaixu Xia's avatar Kaixu Xia Committed by Ulf Hansson
Browse files

mmc: sdhci-pic32: Make pic32_sdhci_probe_platform() void 



pic32_sdhci_probe_platform() always returned 0, so there's no reason for
a return value.  In addition, pic32_sdhci_probe() checked the return value
for possible error which is unnecessary.

Convert pic32_sdhci_probe_platform() to a void function and remove the
return value check. Fix the following Coccinelle warning:

./drivers/mmc/host/sdhci-pic32.c:127:5-8: Unneeded variable: "ret". Return "0" on line 137

Reported-by: default avatarTosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: default avatarKaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1604847648-13036-1-git-send-email-kaixuxia@tencent.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 9f7d4c91

drivers/mmc/host/sdhci-pic32.c

+2 −9
Original line number Diff line number Diff line
@@ -121,10 +121,9 @@ static void pic32_sdhci_shared_bus(struct platform_device *pdev) 
	writel(bus, host->ioaddr + SDH_SHARED_BUS_CTRL);

}



static int pic32_sdhci_probe_platform(struct platform_device *pdev,

static void pic32_sdhci_probe_platform(struct platform_device *pdev,

				      struct pic32_sdhci_priv *pdata)

{

	int ret = 0;

	u32 caps_slot_type;

	struct sdhci_host *host = platform_get_drvdata(pdev);
@@ -133,8 +132,6 @@ static int pic32_sdhci_probe_platform(struct platform_device *pdev, 
	caps_slot_type = (host->caps & SDH_CAPS_SDH_SLOT_TYPE_MASK) >> 30;

	if (caps_slot_type == SDH_SLOT_TYPE_SHARED_BUS)

		pic32_sdhci_shared_bus(pdev);



	return ret;

}



static int pic32_sdhci_probe(struct platform_device *pdev)
@@ -193,11 +190,7 @@ static int pic32_sdhci_probe(struct platform_device *pdev) 
	if (ret)

		goto err_base_clk;



	ret = pic32_sdhci_probe_platform(pdev, sdhci_pdata);

	if (ret) {

		dev_err(&pdev->dev, "failed to probe platform!\n");

		goto err_base_clk;

	}

	pic32_sdhci_probe_platform(pdev, sdhci_pdata);



	ret = sdhci_add_host(host);

	if (ret)