Commit c23bb54f authored by Shannon Nelson's avatar Shannon Nelson Committed by David S. Miller
Browse files

ionic: fix gathering of debug stats 



Don't print stats for which we haven't reserved space as it can
cause nasty memory bashing and related bad behaviors.

Fixes: aa620993 ("ionic: pull per-q stats work out of queue loops")
Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3fb2a54b

drivers/net/ethernet/pensando/ionic/ionic_stats.c

+0 −9
Original line number Diff line number Diff line
@@ -380,15 +380,6 @@ static void ionic_sw_stats_get_txq_values(struct ionic_lif *lif, u64 **buf, 
					  &ionic_dbg_intr_stats_desc[i]);

		(*buf)++;

	}

	for (i = 0; i < IONIC_NUM_DBG_NAPI_STATS; i++) {

		**buf = IONIC_READ_STAT64(&txqcq->napi_stats,

					  &ionic_dbg_napi_stats_desc[i]);

		(*buf)++;

	}

	for (i = 0; i < IONIC_MAX_NUM_NAPI_CNTR; i++) {

		**buf = txqcq->napi_stats.work_done_cntr[i];

		(*buf)++;

	}

	for (i = 0; i < IONIC_MAX_NUM_SG_CNTR; i++) {

		**buf = txstats->sg_cntr[i];

		(*buf)++;