Commit c21ab2af authored by Mike Pattrick's avatar Mike Pattrick Committed by David S. Miller
Browse files

openvswitch: Fix overreporting of drops in dropwatch 



Currently queue_userspace_packet will call kfree_skb for all frames,
whether or not an error occurred. This can result in a single dropped
frame being reported as multiple drops in dropwatch. This functions
caller may also call kfree_skb in case of an error. This patch will
consume the skbs instead and allow caller's to use kfree_skb.

Signed-off-by: default avatarMike Pattrick <mkp@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2109957


Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1100248a

net/openvswitch/datapath.c

+3 −2
Original line number Diff line number Diff line
@@ -558,8 +558,9 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, 
out:

	if (err)

		skb_tx_error(skb);

	kfree_skb(user_skb);

	kfree_skb(nskb);

	consume_skb(user_skb);

	consume_skb(nskb);



	return err;

}