Commit c1efd500 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Avoid unnecessary neighbour updates 



Avoid updating neighbour and adjacency entries in hardware when the
neighbour is already connected and its MAC address did not change. This
can happen, for example, when neighbour transitions between valid states
such as 'NUD_REACHABLE' and 'NUD_DELAY'.

This is especially important for resilient hashing as these updates will
result in adjacency entries being marked as active.

Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40f5429f

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+4 −0
Original line number Diff line number Diff line
@@ -2662,6 +2662,10 @@ static void mlxsw_sp_router_neigh_event_work(struct work_struct *work) 
			goto out;

	}



	if (neigh_entry->connected && entry_connected &&

	    !memcmp(neigh_entry->ha, ha, ETH_ALEN))

		goto out;



	memcpy(neigh_entry->ha, ha, ETH_ALEN);

	mlxsw_sp_neigh_entry_update(mlxsw_sp, neigh_entry, entry_connected);

	mlxsw_sp_nexthop_neigh_update(mlxsw_sp, neigh_entry, !entry_connected,