Commit c1e8ad23 authored by Zhouyi Zhou's avatar Zhouyi Zhou Committed by Greg Kroah-Hartman
Browse files

snsc: check return value of class_create 



	 return value of class_create should be considered in
module init function.

Signed-off-by: default avatarZhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 26ec99b1

drivers/char/snsc.c

+6 −1
Original line number Diff line number Diff line
@@ -385,13 +385,18 @@ scdrv_init(void) 


	event_nasid = ia64_sn_get_console_nasid();



	snsc_class = class_create(THIS_MODULE, SYSCTL_BASENAME);

	if (IS_ERR(snsc_class)) {

		printk("%s: failed to allocate class\n", __func__);

		return PTR_ERR(snsc_class);

	}



	if (alloc_chrdev_region(&first_dev, 0, num_cnodes,

				SYSCTL_BASENAME) < 0) {

		printk("%s: failed to register SN system controller device\n",

		       __func__);

		return -ENODEV;

	}

	snsc_class = class_create(THIS_MODULE, SYSCTL_BASENAME);



	for (cnode = 0; cnode < num_cnodes; cnode++) {

			geoid = cnodeid_get_geoid(cnode);