Commit c1e854a3 authored by Ben Skeggs's avatar Ben Skeggs Committed by Karol Herbst
Browse files

drm/nouveau/nvif: fix potential double-free 



DRM cleanup paths unconditionally call nvif_mmu_dtor() for clients,
which would result in a double-free if nvif_mmu_ctor()'d previously
failed.

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarKarol Herbst <kherbst@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230525003106.3853741-9-skeggsb@gmail.com
parent 55e1a599

drivers/gpu/drm/nouveau/nvif/mmu.c

+3 −0
Original line number Diff line number Diff line
@@ -27,6 +27,9 @@ 
void

nvif_mmu_dtor(struct nvif_mmu *mmu)

{

	if (!nvif_object_constructed(&mmu->object))

		return;



	kfree(mmu->kind);

	kfree(mmu->type);

	kfree(mmu->heap);