Unverified Commit c1be6292 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: qcom: q6apm: do not close GPR port before closing graph 



Closing GPR port before graph close can result in un handled notifications
from DSP, this results in spam of errors from GPR driver as there is no
one to handle these notification at that point in time.

Fix this by closing GPR port after graph close is finished.

Fixes: 5477518b ("ASoC: qdsp6: audioreach: add q6apm support")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230705131842.41584-1-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c03226ba

sound/soc/qcom/qdsp6/q6apm.c

+6 −1
Original line number Diff line number Diff line
@@ -511,6 +511,8 @@ static int graph_callback(struct gpr_resp_pkt *data, void *priv, int op) 


	switch (hdr->opcode) {

	case DATA_CMD_RSP_WR_SH_MEM_EP_DATA_BUFFER_DONE_V2:

		if (!graph->ar_graph)

			break;

		client_event = APM_CLIENT_EVENT_DATA_WRITE_DONE;

		mutex_lock(&graph->lock);

		token = hdr->token & APM_WRITE_TOKEN_MASK;
@@ -544,6 +546,8 @@ static int graph_callback(struct gpr_resp_pkt *data, void *priv, int op) 
		wake_up(&graph->cmd_wait);

		break;

	case DATA_CMD_RSP_RD_SH_MEM_EP_DATA_BUFFER_V2:

		if (!graph->ar_graph)

			break;

		client_event = APM_CLIENT_EVENT_DATA_READ_DONE;

		mutex_lock(&graph->lock);

		rd_done = data->payload;
@@ -649,8 +653,9 @@ int q6apm_graph_close(struct q6apm_graph *graph) 
{

	struct audioreach_graph *ar_graph = graph->ar_graph;



	gpr_free_port(graph->port);

	graph->ar_graph = NULL;

	kref_put(&ar_graph->refcount, q6apm_put_audioreach_graph);

	gpr_free_port(graph->port);

	kfree(graph);



	return 0;