Commit c1b9ca36 authored by Johan Hovold's avatar Johan Hovold Committed by Kalle Valo
Browse files

ath6kl: fix division by zero in send path 



Add the missing endpoint max-packet sanity check to probe() to avoid
division by zero in ath10k_usb_hif_tx_sg() in case a malicious device
has broken descriptors (or when doing descriptor fuzz testing).

Note that USB core will reject URBs submitted for endpoints with zero
wMaxPacketSize but that drivers doing packet-size calculations still
need to handle this (cf. commit 2548288b ("USB: Fix: Don't skip
endpoint descriptors with maxpacket=0")).

Fixes: 9cbee358 ("ath6kl: add full USB support")
Cc: stable@vger.kernel.org      # 3.5
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211027080819.6675-3-johan@kernel.org
parent a006acb9

drivers/net/wireless/ath/ath6kl/usb.c

+5 −0
Original line number Diff line number Diff line
@@ -340,6 +340,11 @@ static int ath6kl_usb_setup_pipe_resources(struct ath6kl_usb *ar_usb) 
				   le16_to_cpu(endpoint->wMaxPacketSize),

				   endpoint->bInterval);

		}



		/* Ignore broken descriptors. */

		if (usb_endpoint_maxp(endpoint) == 0)

			continue;



		urbcount = 0;



		pipe_num =