Commit c1b6ad9a authored by Changcheng Deng's avatar Changcheng Deng Committed by Abel Vesa
Browse files

clk: imx: Use div64_ul instead of do_div 



do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarChangcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: default avatarAbel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20211118080634.165275-1-deng.changcheng@zte.com.cn


Signed-off-by: default avatarAbel Vesa <abel.vesa@nxp.com>
parent b5e29cf7

drivers/clk/imx/clk-pllv3.c

+3 −3
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate, 
	div = rate / parent_rate;

	temp64 = (u64) (rate - div * parent_rate);

	temp64 *= mfd;

	do_div(temp64, parent_rate);

	temp64 = div64_ul(temp64, parent_rate);

	mfn = temp64;



	temp64 = (u64)parent_rate;
@@ -277,7 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate, 
	div = rate / parent_rate;

	temp64 = (u64) (rate - div * parent_rate);

	temp64 *= mfd;

	do_div(temp64, parent_rate);

	temp64 = div64_ul(temp64, parent_rate);

	mfn = temp64;



	val = readl_relaxed(pll->base);
@@ -334,7 +334,7 @@ static struct clk_pllv3_vf610_mf clk_pllv3_vf610_rate_to_mf( 
		/* rate = parent_rate * (mfi + mfn/mfd) */

		temp64 = rate - parent_rate * mf.mfi;

		temp64 *= mf.mfd;

		do_div(temp64, parent_rate);

		temp64 = div64_ul(temp64, parent_rate);

		mf.mfn = temp64;

	}