Commit c1b4de6a authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron
Browse files

iio: light: noa1305: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928014156.1491-4-caihuoqing@baidu.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 8283b954

drivers/iio/light/noa1305.c

+3 −4
Original line number Diff line number Diff line
@@ -217,10 +217,9 @@ static int noa1305_probe(struct i2c_client *client, 
	priv = iio_priv(indio_dev);



	priv->vin_reg = devm_regulator_get(&client->dev, "vin");

	if (IS_ERR(priv->vin_reg)) {

		dev_err(&client->dev, "get regulator vin failed\n");

		return PTR_ERR(priv->vin_reg);

	}

	if (IS_ERR(priv->vin_reg))

		return dev_err_probe(&client->dev, PTR_ERR(priv->vin_reg),

				     "get regulator vin failed\n");



	ret = regulator_enable(priv->vin_reg);

	if (ret) {