Commit c1a7c2ce authored by Nick Desaulniers's avatar Nick Desaulniers Committed by Rafael J. Wysocki
Browse files

ACPICA: fix -Wfallthrough 



ACPICA commit 4b9135f5774caa796ddf826448811e8e7f08ef2f

GCC 7.1 gained -Wimplicit-fallthrough to warn on implicit fallthrough,
as well as __attribute__((__fallthrough__)) and comments to explicitly
denote that cases of fallthrough were intentional. Clang also supports
this warning and statement attribute, but not the comment form.

Robert Moore provides additional context about the lint comments being
removed. They were for "an old version of PC-Lint, which we don't use
anymore." Drop those.

This will help us enable -Wimplicit-fallthrough throughout the Linux
kernel.

Suggested-by: default avatarRobert Moore <robert.moore@intel.com>
Reported-by: default avatarJon Hunter <jonathanh@nvidia.com>

Link: https://github.com/acpica/acpica/commit/4b9135f5


Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarErik Kaneda <erik.kaneda@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 25d866c4

drivers/acpi/acpica/dscontrol.c

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ acpi_ds_exec_begin_control_op(struct acpi_walk_state *walk_state, 
			}

		}



		/*lint -fallthrough */

		ACPI_FALLTHROUGH;



	case AML_IF_OP:

		/*

drivers/acpi/acpica/dswexec.c

+1 −2
Original line number Diff line number Diff line
@@ -598,8 +598,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state) 
					break;

				}



				/* Fall through */

				/*lint -fallthrough */

				ACPI_FALLTHROUGH;



			case AML_INT_EVAL_SUBTREE_OP:

drivers/acpi/acpica/dswload.c

+1 −1
Original line number Diff line number Diff line
@@ -224,7 +224,7 @@ acpi_ds_load1_begin_op(struct acpi_walk_state *walk_state, 
				break;

			}



			/*lint -fallthrough */

			ACPI_FALLTHROUGH;



		default:

drivers/acpi/acpica/dswload2.c

+1 −1
Original line number Diff line number Diff line
@@ -214,7 +214,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state, 
				break;

			}



			/*lint -fallthrough */

			ACPI_FALLTHROUGH;



		default:

drivers/acpi/acpica/exfldio.c

+1 −1
Original line number Diff line number Diff line
@@ -434,7 +434,7 @@ acpi_ex_field_datum_io(union acpi_operand_object *obj_desc, 
		 * region_field case and write the datum to the Operation Region

		 */



		/*lint -fallthrough */

		ACPI_FALLTHROUGH;



	case ACPI_TYPE_LOCAL_REGION_FIELD:

		/*