Commit c19350ef authored by Koby Elbaz's avatar Koby Elbaz Committed by Oded Gabbay
Browse files

accel/habanalabs: don't wait for STS_OK after sending COMMS WFE 



Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state).
Once sent, FW's CPU isn't expected to continue communicating with LKD.
Therefore, the stage of waiting for COMMS_STS_OK should be skipped or
else waiting for COMMS_STS_OK will simply timeout, which will trigger
unexpected behavior.

Signed-off-by: default avatarKoby Elbaz <kelbaz@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 802f25b6

drivers/accel/habanalabs/common/firmware_if.c

+1 −1
Original line number Diff line number Diff line
@@ -1278,7 +1278,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev) 
	/* Stop device CPU to make sure nothing bad happens */

	if (hdev->asic_prop.dynamic_fw_load) {

		rc = hl_fw_dynamic_send_protocol_cmd(hdev, &hdev->fw_loader,

				COMMS_GOTO_WFE, 0, true,

				COMMS_GOTO_WFE, 0, false,

				hdev->fw_loader.cpu_timeout);

		if (rc)

			dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");