Unverified Commit c18bbac3 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

spi: atmel-quadspi: Don't leak clk enable count in pm resume 



The pm resume call is supposed to enable two clocks. If the second enable
fails the callback reports failure but doesn't undo the first enable.

So call clk_disable() for the first clock when clk_enable() for the second
one fails.

Fixes: 4a2f83b7 ("spi: atmel-quadspi: add runtime pm support")
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20230317084232.142257-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent eeac8ede

drivers/spi/atmel-quadspi.c

+5 −1
Original line number Diff line number Diff line
@@ -786,7 +786,11 @@ static int __maybe_unused atmel_qspi_runtime_resume(struct device *dev) 
	if (ret)

		return ret;



	return clk_enable(aq->qspick);

	ret = clk_enable(aq->qspick);

	if (ret)

		clk_disable(aq->pclk);



	return ret;

}



static const struct dev_pm_ops __maybe_unused atmel_qspi_pm_ops = {