Commit c15c2ec0 authored by Boleyn Su's avatar Boleyn Su Committed by David Sterba
Browse files

btrfs: check correct variable after allocation in btrfs_backref_iter_alloc 



The `if (!ret)` check will always be false and it may result in
ret->path being dereferenced while it is a NULL pointer.

Fixes: a37f232b ("btrfs: backref: introduce the skeleton of btrfs_backref_iter")
CC: stable@vger.kernel.org # 5.8+
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarBoleyn Su <boleynsu@google.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent faa00889

fs/btrfs/backref.c

+1 −1
Original line number Diff line number Diff line
@@ -2303,7 +2303,7 @@ struct btrfs_backref_iter *btrfs_backref_iter_alloc( 
		return NULL;



	ret->path = btrfs_alloc_path();

	if (!ret) {

	if (!ret->path) {

		kfree(ret);

		return NULL;

	}