Commit c13899f1 authored Feb 01, 2021 by Alex Elder Committed by Jakub Kicinski Feb 02, 2021

net: ipa: use the right accessor in ipa_endpoint_status_skip()



When extracting the destination endpoint ID from the status in
ipa_endpoint_status_skip(), u32_get_bits() is used.  This happens to
work, but it's wrong: the structure field is only 8 bits wide
instead of 32.

Fix this by using u8_get_bits() to get the destination endpoint ID.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 088f8a23

drivers/net/ipa/ipa_endpoint.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1164,7 +1164,7 @@ static bool ipa_endpoint_status_skip(struct ipa_endpoint *endpoint,
		return true;
		if (!status->pkt_len)
		return true;
		endpoint_id = u32_get_bits(status->endp_dst_idx,
		endpoint_id = u8_get_bits(status->endp_dst_idx,
		IPA_STATUS_DST_IDX_FMASK);
		if (endpoint_id != endpoint->endpoint_id)
		return true;