Commit c0f3332c authored by Erwan Le Ray's avatar Erwan Le Ray Committed by Greg Kroah-Hartman
Browse files

serial: stm32: clean wakeup handling in serial_suspend 



Remove useless call to stm32_usart_serial_en_wakeup() routine in suspend
callback. When called with "false" argument, this routine is clearing UESM
and WUFIE bits if usart is not wakeup source. Those bits are already
cleared in set_termios(), and then in serial_resume() callback when usart
is wakeup source.

Signed-off-by: default avatarAlexandre Torgue <alexandre.torgue@foss.st.com>
Signed-off-by: default avatarErwan Le Ray <erwan.leray@foss.st.com>
Link: https://lore.kernel.org/r/20210319184253.5841-3-erwan.leray@foss.st.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1631eeea

drivers/tty/serial/stm32-usart.c

+0 −2
Original line number Diff line number Diff line
@@ -1536,8 +1536,6 @@ static int __maybe_unused stm32_usart_serial_suspend(struct device *dev) 


	if (device_may_wakeup(dev) || device_wakeup_path(dev))

		stm32_usart_serial_en_wakeup(port, true);

	else

		stm32_usart_serial_en_wakeup(port, false);



	/*

	 * When "no_console_suspend" is enabled, keep the pinctrl default state