Commit c0cc75f8 authored by NeilBrown's avatar NeilBrown
Browse files

md: discard StateChanged device flag. 



This was needed when sysfs files could only be 'notified'
from process context.  Now that we have sys_notify_direct,
we can call it directly from an interrupt.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 7b92813c

drivers/md/md.c

+1 −6
Original line number Diff line number Diff line
@@ -5970,7 +5970,7 @@ void md_error(mddev_t *mddev, mdk_rdev_t *rdev) 
	mddev->pers->error_handler(mddev,rdev);

	if (mddev->degraded)

		set_bit(MD_RECOVERY_RECOVER, &mddev->recovery);

	set_bit(StateChanged, &rdev->flags);

	sysfs_notify_dirent(rdev->sysfs_state);

	set_bit(MD_RECOVERY_INTR, &mddev->recovery);

	set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);

	md_wakeup_thread(mddev->thread);
@@ -6962,11 +6962,6 @@ void md_check_recovery(mddev_t *mddev) 
		if (mddev->flags)

			md_update_sb(mddev, 0);



		list_for_each_entry(rdev, &mddev->disks, same_set)

			if (test_and_clear_bit(StateChanged, &rdev->flags))

				sysfs_notify_dirent(rdev->sysfs_state);





		if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) &&

		    !test_bit(MD_RECOVERY_DONE, &mddev->recovery)) {

			/* resync/recovery still happening */

drivers/md/md.h

+0 −3
Original line number Diff line number Diff line
@@ -74,9 +74,6 @@ struct mdk_rdev_s 
#define Blocked		8		/* An error occured on an externally

					 * managed array, don't allow writes

					 * until it is cleared */

#define StateChanged	9		/* Faulty or Blocked has changed during

					 * interrupt, so it needs to be

					 * notified by the thread */

	wait_queue_head_t blocked_wait;



	int desc_nr;			/* descriptor index in the superblock */