Commit c0b06758 authored Aug 01, 2023 by Arnaldo Carvalho de Melo Committed by Arnaldo Carvalho de Melo Aug 08, 2023

Revert "perf report: Append inlines to non-DWARF callchains"



This reverts commit 46d21ec0.

The tests were made with a specific workload, further tests on a
recently updated fedora 38 system with a system wide perf.data file
shows 'perf report' taking excessive time resolving inlines in vmlinux,
so lets revert this until a full investigation and improvement on the
addr2line support code is made.

Reported-by: Jesper Dangaard Brouer <hawk@kernel.org>
Acked-by: Artem Savkov <asavkov@redhat.com>
Tested-by: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/ZMl8VyhdwhClTM5g@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 52a93d39

tools/perf/util/machine.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -45,7 +45,6 @@

		static void __machine__remove_thread(struct machine machine, struct thread_rb_node nd,
		struct thread *th, bool lock);
		static int append_inlines(struct callchain_cursor cursor, struct map_symbol ms, u64 ip);

		static struct dso machine__kernel_dso(struct machine machine)
		{
		@@ -2385,10 +2384,6 @@ static int add_callchain_ip(struct thread *thread,
		ms.maps = maps__get(al.maps);
		ms.map = map__get(al.map);
		ms.sym = al.sym;

		if (!branch && append_inlines(cursor, &ms, ip) == 0)
		goto out;

		srcline = callchain_srcline(&ms, al.addr);
		err = callchain_cursor_append(cursor, ip, &ms,
		branch, flags, nr_loop_iter,