Commit c0a6e5ee authored by Zhang Qilong's avatar Zhang Qilong Committed by Bjorn Andersson
Browse files

remoteproc: qcom: pas: fix error handling in adsp_pds_enable 



If the pm_runtime_get_sync failed in adsp_pds_enable when
loop (i), The unroll_pd_votes will start from (i - 1), and
it will resulted in following problems:

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to pm_runtime_put_noidle will result in
     reference leak.

  2) Have not reset pds[i] performance state.

Then we fix it.

Fixes: 17ee2fb4 ("remoteproc: qcom: pas: Vote for active/proxy power domains")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201102143554.144707-1-zhangqilong3@huawei.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent aa37448f

drivers/remoteproc/qcom_q6v5_pas.c

+4 −1
Original line number Diff line number Diff line
@@ -99,9 +99,12 @@ static int adsp_pds_enable(struct qcom_adsp *adsp, struct device **pds, 
	for (i = 0; i < pd_count; i++) {

		dev_pm_genpd_set_performance_state(pds[i], INT_MAX);

		ret = pm_runtime_get_sync(pds[i]);

		if (ret < 0)

		if (ret < 0) {

			pm_runtime_put_noidle(pds[i]);

			dev_pm_genpd_set_performance_state(pds[i], 0);

			goto unroll_pd_votes;

		}

	}



	return 0;