Commit c0a50cd3 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: lpfc: Return DID_TRANSPORT_DISRUPTED instead of DID_REQUEUE 

When the driver hits an internal error condition returning DID_REQUEUE the
I/O will be retried on the same ITL nexus.  This will inhibit multipathing,
resulting in endless retries even if the error could have been resolved by
using a different ITL nexus.  Return DID_TRANSPORT_DISRUPTED to allow for
multipath to engage and route I/O to another ITL nexus.

Link: https://lore.kernel.org/r/20220824060033.138661-1-hare@suse.de


Reviewed-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 785538bf

drivers/scsi/lpfc/lpfc_scsi.c

+2 −2
Original line number Diff line number Diff line
@@ -4272,7 +4272,7 @@ lpfc_fcp_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn, 
		    lpfc_cmd->result == IOERR_ABORT_REQUESTED ||

		    lpfc_cmd->result == IOERR_RPI_SUSPENDED ||

		    lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {

			cmd->result = DID_REQUEUE << 16;

			cmd->result = DID_TRANSPORT_DISRUPTED << 16;

			break;

		}

		if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||
@@ -4562,7 +4562,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, 
			    lpfc_cmd->result == IOERR_NO_RESOURCES ||

			    lpfc_cmd->result == IOERR_ABORT_REQUESTED ||

			    lpfc_cmd->result == IOERR_SLER_CMD_RCV_FAILURE) {

				cmd->result = DID_REQUEUE << 16;

				cmd->result = DID_TRANSPORT_DISRUPTED << 16;

				break;

			}

			if ((lpfc_cmd->result == IOERR_RX_DMA_FAILED ||