Commit c0904516 authored Jan 31, 2022 by Maxim Mikityanskiy Committed by Saeed Mahameed Mar 18, 2022

net/mlx5e: Remove assignment of inline_hdr.sz on XDP TX



When MPWQE is disabled, mlx5e_open_xdpsq prefills the common fields of
WQEs in the XDP SQ to save time when sending packets. One of such fields
is eseg->inline_hdr.sz, which can be either 0 or MLX5E_XDP_MIN_INLINE,
depending on the inline mode of the SQ.

The inline mode can't change during the lifetime of the SQ, so setting
this field again in mlx5e_xmit_xdp_frame is redundant. Moreover, the
xmit function only sets it to MLX5E_XDP_MIN_INLINE, but not to 0 in the
other case.

This commit removes the redundant assignment in mlx5e_xmit_xdp_frame.

Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

parent 49529a17

drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -343,7 +343,6 @@ mlx5e_xmit_xdp_frame(struct mlx5e_xdpsq sq, struct mlx5e_xmit_data xdptxd,
		/* copy the inline part if required */
		if (sq->min_inline_mode != MLX5_INLINE_MODE_NONE) {
		memcpy(eseg->inline_hdr.start, xdptxd->data, sizeof(eseg->inline_hdr.start));
		eseg->inline_hdr.sz = cpu_to_be16(MLX5E_XDP_MIN_INLINE);
		memcpy(dseg, xdptxd->data + sizeof(eseg->inline_hdr.start),
		MLX5E_XDP_MIN_INLINE - sizeof(eseg->inline_hdr.start));
		dma_len -= MLX5E_XDP_MIN_INLINE;