Commit c0713540 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: fix leaks on IOPOLL and CQE_SKIP 



If all completed requests in io_do_iopoll() were marked with
REQ_F_CQE_SKIP, we'll not only skip CQE posting but also
io_free_batch_list() leaking memory and resources.

Move @nr_events increment before REQ_F_CQE_SKIP check. We'll potentially
return the value greater than the real one, but iopolling will deal with
it and the userspace will re-iopoll if needed. In anyway, I don't think
there are many use cases for REQ_F_CQE_SKIP + IOPOLL.

Fixes: 83a13a41 ("io_uring: tweak iopoll CQE_SKIP event counting")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/5072fc8693fbfd595f89e5d4305bfcfd5d2f0a64.1650186611.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 323b190b

fs/io_uring.c

+1 −2
Original line number Diff line number Diff line
@@ -2797,11 +2797,10 @@ static int io_do_iopoll(struct io_ring_ctx *ctx, bool force_nonspin) 
		/* order with io_complete_rw_iopoll(), e.g. ->result updates */

		if (!smp_load_acquire(&req->iopoll_completed))

			break;

		nr_events++;

		if (unlikely(req->flags & REQ_F_CQE_SKIP))

			continue;



		__io_fill_cqe_req(req, req->result, io_put_kbuf(req, 0));

		nr_events++;

	}



	if (unlikely(!nr_events))