Unverified Commit c04efbfd authored by 倪琛's avatar 倪琛 Committed by Mark Brown
Browse files

ASoC: hdaudio.c: Add missing check for devm_kstrdup 



Because of the potential failure of the devm_kstrdup(), the
dl[i].codecs->name could be NULL.
Therefore, we need to check it and return -ENOMEM in order to transfer
the error.

Fixes: 97030a43 ("ASoC: Intel: avs: Add HDAudio machine board")
Signed-off-by: default avatarChen Ni <nichen@iscas.ac.cn>
Reviewed-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230915021344.3078-1-nichen@iscas.ac.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bb0216d4

sound/soc/intel/avs/boards/hdaudio.c

+3 −0
Original line number Diff line number Diff line
@@ -55,6 +55,9 @@ static int avs_create_dai_links(struct device *dev, struct hda_codec *codec, int 
			return -ENOMEM;



		dl[i].codecs->name = devm_kstrdup(dev, cname, GFP_KERNEL);

		if (!dl[i].codecs->name)

			return -ENOMEM;



		dl[i].codecs->dai_name = pcm->name;

		dl[i].num_codecs = 1;

		dl[i].num_cpus = 1;