Commit c04c9966 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Greg Kroah-Hartman
Browse files

staging: hikey9xx: phy-hi3670-usb3: hi3670_is_abbclk_seleted() returns bool 



There are a few issues on this function:

1. Instead of using 1/0 for true/false, change the type to boolean;
2. there's a typo there:
	seleted -> selected
3. It's logic is reversed.

Address them.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/a579004cfa0cb3cca55c2124a8574a7aeb4eacc3.1611052729.git.mchehab+huawei@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 00c5c968

drivers/staging/hikey9xx/phy-hi3670-usb3.c

+7 −7
Original line number Diff line number Diff line
@@ -326,24 +326,24 @@ static int hi3670_phy_set_params(struct hi3670_priv *priv) 
	return ret;

}



static int hi3670_is_abbclk_seleted(struct hi3670_priv *priv)

static bool hi3670_is_abbclk_selected(struct hi3670_priv *priv)

{

	u32 reg;



	if (!priv->sctrl) {

		dev_err(priv->dev, "priv->sctrl is null!\n");

		return 1;

		return false;

	}



	if (regmap_read(priv->sctrl, SCTRL_SCDEEPSLEEPED, &reg)) {

		dev_err(priv->dev, "SCTRL_SCDEEPSLEEPED read failed!\n");

		return 1;

		return false;

	}



	if ((reg & USB_CLK_SELECTED) == 0)

		return 1;

		return false;



	return 0;

	return true;

}



static int hi3670_config_phy_clock(struct hi3670_priv *priv)
@@ -351,7 +351,7 @@ static int hi3670_config_phy_clock(struct hi3670_priv *priv) 
	u32 val, mask;

	int ret;



	if (hi3670_is_abbclk_seleted(priv)) {

	if (!hi3670_is_abbclk_selected(priv)) {

		/* usb refclk iso disable */

		ret = regmap_write(priv->peri_crg, PERI_CRG_ISODIS,

				   USB_REFCLK_ISO_EN);
@@ -568,7 +568,7 @@ static int hi3670_phy_exit(struct phy *phy) 
	if (ret)

		goto out;



	if (hi3670_is_abbclk_seleted(priv)) {

	if (!hi3670_is_abbclk_selected(priv)) {

		/* disable usb_tcxo_en */

		ret = regmap_write(priv->pctrl, PCTRL_PERI_CTRL3,

				   USB_TCXO_EN << PCTRL_PERI_CTRL3_MSK_START);