Commit c03496b3 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: add a notice about possible leak resources 



Calling acpi_bus_get_device() may end allocating resources that
aren't freed. So, add a notice about that, as, if those drivers
get out of staging, we may need some changes.

Fixes: 0d64e942 ("media: atomisp: Add some ACPI detection info")
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 814634b8

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+2 −1
Original line number Diff line number Diff line
@@ -1317,9 +1317,10 @@ static int gc0310_probe(struct i2c_client *client) 
		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}



	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()





	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

+1 −1
Original line number Diff line number Diff line
@@ -1059,9 +1059,9 @@ static int gc2235_probe(struct i2c_client *client) 
		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}



	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

drivers/staging/media/atomisp/i2c/atomisp-lm3554.c

+1 −1
Original line number Diff line number Diff line
@@ -858,9 +858,9 @@ static int lm3554_probe(struct i2c_client *client) 
		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}



	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	flash = kzalloc(sizeof(*flash), GFP_KERNEL);

	if (!flash)

drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c

+1 −1
Original line number Diff line number Diff line
@@ -1824,9 +1824,9 @@ static int mt9m114_probe(struct i2c_client *client) 
		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}



	pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	/* Setup sensor configuration structure */

	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

drivers/staging/media/atomisp/i2c/atomisp-ov2680.c

+1 −1
Original line number Diff line number Diff line
@@ -1251,9 +1251,9 @@ static int ov2680_probe(struct i2c_client *client) 
		dev_err(&client->dev, "Error could not get ACPI device\n");

		return -ENODEV;

	}



	dev_info(&client->dev, "%s: ACPI detected it on bus ID=%s, HID=%s\n",

		__func__, acpi_device_bid(adev), acpi_device_hid(adev));

	// FIXME: may need to release resources allocated by acpi_bus_get_device()



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)