Commit bfc48f1b authored by Xin Xiong's avatar Xin Xiong Committed by David S. Miller
Browse files

net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change() 



The issue happens on some error handling paths. When the function
fails to grab the object `xprt`, it simply returns 0, forgetting to
decrease the reference count of another object `xps`, which is
increased by rpc_sysfs_xprt_kobj_get_xprt_switch(), causing refcount
leaks. Also, the function forgets to check whether `xps` is valid
before using it, which may result in NULL-dereferencing issues.

Fix it by adding proper error handling code when either `xprt` or
`xps` is NULL.

Fixes: 5b7eb784 ("SUNRPC: take a xprt offline using sysfs")
Signed-off-by: default avatarXin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: default avatarXin Tan <tanxin.ctf@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 86d2155e

net/sunrpc/sysfs.c

+4 −2
Original line number Diff line number Diff line
@@ -291,8 +291,10 @@ static ssize_t rpc_sysfs_xprt_state_change(struct kobject *kobj, 
	int offline = 0, online = 0, remove = 0;

	struct rpc_xprt_switch *xps = rpc_sysfs_xprt_kobj_get_xprt_switch(kobj);



	if (!xprt)

		return 0;

	if (!xprt || !xps) {

		count = 0;

		goto out_put;

	}



	if (!strncmp(buf, "offline", 7))

		offline = 1;