Unverified Commit bfc430ca authored by Barry Song's avatar Barry Song Committed by Mark Brown
Browse files

spi: spi-qcom-qspi: replace spin_lock_irqsave by spin_lock in hard IRQ 



It is redundant to do irqsave and irqrestore in hardIRQ context.

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200910100246.32696-1-song.bao.hua@hisilicon.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d9f0cf9f

drivers/spi/spi-qcom-qspi.c

+2 −3
Original line number Diff line number Diff line
@@ -420,9 +420,8 @@ static irqreturn_t qcom_qspi_irq(int irq, void *dev_id) 
	u32 int_status;

	struct qcom_qspi *ctrl = dev_id;

	irqreturn_t ret = IRQ_NONE;

	unsigned long flags;



	spin_lock_irqsave(&ctrl->lock, flags);

	spin_lock(&ctrl->lock);



	int_status = readl(ctrl->base + MSTR_INT_STATUS);

	writel(int_status, ctrl->base + MSTR_INT_STATUS);
@@ -450,7 +449,7 @@ static irqreturn_t qcom_qspi_irq(int irq, void *dev_id) 
		spi_finalize_current_transfer(dev_get_drvdata(ctrl->dev));

	}



	spin_unlock_irqrestore(&ctrl->lock, flags);

	spin_unlock(&ctrl->lock);

	return ret;

}