Commit bfbb307c authored by Dan Carpenter's avatar Dan Carpenter Committed by Paolo Bonzini
Browse files

KVM: VMX: Set failure code in prepare_vmcs02() 



The error paths in the prepare_vmcs02() function are supposed to set
*entry_failure_code but this path does not.  It leads to using an
uninitialized variable in the caller.

Fixes: 71f73470 ("KVM: nVMX: Load GUEST_IA32_PERF_GLOBAL_CTRL MSR on VM-Entry")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Message-Id: <20211130125337.GB24578@kili>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent ef8b4b72

arch/x86/kvm/vmx/nested.c

+3 −1
Original line number Diff line number Diff line
@@ -2591,8 +2591,10 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12, 


	if ((vmcs12->vm_entry_controls & VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL) &&

	    WARN_ON_ONCE(kvm_set_msr(vcpu, MSR_CORE_PERF_GLOBAL_CTRL,

				     vmcs12->guest_ia32_perf_global_ctrl)))

				     vmcs12->guest_ia32_perf_global_ctrl))) {

		*entry_failure_code = ENTRY_FAIL_DEFAULT;

		return -EINVAL;

	}



	kvm_rsp_write(vcpu, vmcs12->guest_rsp);

	kvm_rip_write(vcpu, vmcs12->guest_rip);