Commit bfb44502 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bjorn Andersson
Browse files

remoteproc: qcom: fix glink dependencies 



Building the remoteproc drivers into the kernel while the qcom_glink
code is in a loadable module results in a link error:

ld.lld: error: undefined symbol: qcom_glink_ssr_notify
>>> referenced by vmlinux.o:(glink_subdev_unprepare)

Add a Kconfig dependency to avoid this.

Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Fixes: 8527efc5 ("rpmsg: glink: Guard qcom_glink_ssr_notify() with correct config")
Fixes: 5d1f2e3c ("soc: qcom: glink_ssr: Internalize ssr_notifiers")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210204154010.1585457-1-arnd@kernel.org


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent cf34838d

drivers/remoteproc/Kconfig

+5 −0
Original line number Diff line number Diff line
@@ -155,6 +155,7 @@ config QCOM_Q6V5_ADSP 
	depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)

	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n

	depends on QCOM_SYSMON || QCOM_SYSMON=n

	depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=n

	select MFD_SYSCON

	select QCOM_PIL_INFO

	select QCOM_MDT_LOADER
@@ -173,6 +174,7 @@ config QCOM_Q6V5_MSS 
	depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)

	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n

	depends on QCOM_SYSMON || QCOM_SYSMON=n

	depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=n

	select MFD_SYSCON

	select QCOM_MDT_LOADER

	select QCOM_PIL_INFO
@@ -191,6 +193,7 @@ config QCOM_Q6V5_PAS 
	depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)

	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n

	depends on QCOM_SYSMON || QCOM_SYSMON=n

	depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=n

	select MFD_SYSCON

	select QCOM_PIL_INFO

	select QCOM_MDT_LOADER
@@ -211,6 +214,7 @@ config QCOM_Q6V5_WCSS 
	depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)

	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n

	depends on QCOM_SYSMON || QCOM_SYSMON=n

	depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=n

	select MFD_SYSCON

	select QCOM_MDT_LOADER

	select QCOM_PIL_INFO
@@ -244,6 +248,7 @@ config QCOM_WCNSS_PIL 
	depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n

	depends on QCOM_SMEM

	depends on QCOM_SYSMON || QCOM_SYSMON=n

	depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=n

	select QCOM_MDT_LOADER

	select QCOM_PIL_INFO

	select QCOM_RPROC_COMMON