Commit bf75eb44 authored by Yuan Can's avatar Yuan Can Committed by Joerg Roedel
Browse files

iommu: Remove duplicate ida_free in iommu_group_alloc 



In the iommu_group_alloc, when the kobject_init_and_add
failed, the group->kobj is associate with iommu_group_ktype,
thus its release function iommu_group_release will be called
by the following kobject_put. The iommu_group_release calls
ida_free with the group->id, so we do not need to do it before
kobject_put.

Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20220815031423.94548-1-yuancan@huawei.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 28394501

drivers/iommu/iommu.c

+0 −1
Original line number Diff line number Diff line
@@ -654,7 +654,6 @@ struct iommu_group *iommu_group_alloc(void) 
	ret = kobject_init_and_add(&group->kobj, &iommu_group_ktype,

				   NULL, "%d", group->id);

	if (ret) {

		ida_free(&iommu_group_ida, group->id);

		kobject_put(&group->kobj);

		return ERR_PTR(ret);

	}