Commit bf6067a6 authored Jul 03, 2023 by Andy Shevchenko Committed by Rafael J. Wysocki Jul 04, 2023

ACPI: platform: Move SMB0001 HID to the header and reuse



There are at least two places in the kernel that are using
the SMB0001 HID. Make it to be available via acpi_drivers.h
header file. While at it, replace hard coded one with a
definition.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
Link: https://lore.kernel.org/r/20230621151652.79579-2-andriy.shevchenko@linux.intel.com


Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent cefbd80b

drivers/acpi/acpi_platform.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@ static const struct acpi_device_id forbidden_id_list[] = {
		{"PNP0000", 0}, /* PIC */
		{"PNP0100", 0}, /* Timer */
		{"PNP0200", 0}, /* AT DMA Controller */
		{"SMB0001", ACPI_ALLOW_WO_RESOURCES}, /* ACPI SMBUS virtual device */
		{ACPI_SMBUS_MS_HID, ACPI_ALLOW_WO_RESOURCES}, /* ACPI SMBUS virtual device */
		{ }
		};

drivers/i2c/busses/i2c-scmi.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -13,9 +13,6 @@
		#include <linux/i2c.h>
		#include <linux/acpi.h>

		/* SMBUS HID definition as supported by Microsoft Windows */
		#define ACPI_SMBUS_MS_HID "SMB0001"

		struct smbus_methods_t {
		char *mt_info;
		char *mt_sbr;

include/acpi/acpi_drivers.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,8 @@
		#define ACPI_BAY_HID "LNXIOBAY"
		#define ACPI_DOCK_HID "LNXDOCK"
		#define ACPI_ECDT_HID "LNXEC"
		/* SMBUS HID definition as supported by Microsoft Windows */
		#define ACPI_SMBUS_MS_HID "SMB0001"
		/* Quirk for broken IBM BIOSes */
		#define ACPI_SMBUS_IBM_HID "SMBUSIBM"