Unverified Commit bf4a9b24 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

ASoC: samsung: Fix refcount leak in aries_audio_probe 



of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
If extcon_find_edev_by_node() fails, it doesn't call of_node_put()
Calling of_node_put() after extcon_find_edev_by_node() to fix this.

Fixes: 7a3a7671 ("ASoC: samsung: Add driver for Aries boards")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220512043828.496-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8b7a4075

sound/soc/samsung/aries_wm8994.c

+1 −1
Original line number Diff line number Diff line
@@ -585,10 +585,10 @@ static int aries_audio_probe(struct platform_device *pdev) 


	extcon_np = of_parse_phandle(np, "extcon", 0);

	priv->usb_extcon = extcon_find_edev_by_node(extcon_np);

	of_node_put(extcon_np);

	if (IS_ERR(priv->usb_extcon))

		return dev_err_probe(dev, PTR_ERR(priv->usb_extcon),

				     "Failed to get extcon device");

	of_node_put(extcon_np);



	priv->adc = devm_iio_channel_get(dev, "headset-detect");

	if (IS_ERR(priv->adc))