Commit bef11f1e authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

wifi: brcmfmac: use strreplace() in brcmf_of_probe() 



The for loop in brcmf_of_probe() would ideally end with something like
"i <= strlen(board_type)" instead of "i < board_type[i]".  But
fortunately, the two are equivalent.

Anyway, it's simpler to use strreplace() instead.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Suggested-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/YqrhsKcjEA7B2pC4@kili
parent 70c898d4

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c

+1 −5
Original line number Diff line number Diff line
@@ -72,7 +72,6 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, 
	/* Set board-type to the first string of the machine compatible prop */

	root = of_find_node_by_path("/");

	if (root) {

		int i;

		char *board_type;

		const char *tmp;
@@ -84,10 +83,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type, 
			of_node_put(root);

			return;

		}

		for (i = 0; i < board_type[i]; i++) {

			if (board_type[i] == '/')

				board_type[i] = '-';

		}

		strreplace(board_type, '/', '-');

		settings->board_type = board_type;



		of_node_put(root);