Commit bec99e52 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: Reduce some indirection in v3 hw driver 

Sometimes local functions are called indirectly from the hw driver, which
only makes the code harder to follow. Remove these.

Method .hw_init is only called from platform driver probe, which is not
relevant, so don't set this either.

Link: https://lore.kernel.org/r/1606207594-196362-2-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c6131854

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+2 −3
Original line number Diff line number Diff line
@@ -3142,7 +3142,6 @@ static struct scsi_host_template sht_v3_hw = { 
};



static const struct hisi_sas_hw hisi_sas_v3_hw = {

	.hw_init = hisi_sas_v3_init,

	.setup_itct = setup_itct_v3_hw,

	.get_wideport_bitmap = get_wideport_bitmap_v3_hw,

	.complete_hdr_size = sizeof(struct hisi_sas_complete_v3_hdr),
@@ -3322,7 +3321,7 @@ hisi_sas_v3_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	if (rc)

		goto err_out_register_ha;



	rc = hisi_hba->hw->hw_init(hisi_hba);

	rc = hisi_sas_v3_init(hisi_hba);

	if (rc)

		goto err_out_register_ha;
@@ -3495,7 +3494,7 @@ static int _resume_v3_hw(struct device *device) 
		scsi_remove_host(shost);

		return rc;

	}

	hisi_hba->hw->phys_init(hisi_hba);

	phys_init_v3_hw(hisi_hba);

	sas_resume_ha(sha);

	clear_bit(HISI_SAS_RESET_BIT, &hisi_hba->flags);