Commit beb18bb2 authored by Basavaraj Natikar's avatar Basavaraj Natikar Committed by Jiri Kosina
Browse files

HID: amd_sfh: Change dev_err to dev_dbg for additional debug info 



Users should only be notified at most one time on systems doesn't have
any sensors connected or non-supported systems.

Check the return code and don't display error messages in those
conditions.

Signed-off-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a1f76426

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

+3 −3
Original line number Diff line number Diff line
@@ -286,13 +286,13 @@ int amd_sfh1_1_init(struct amd_mp2_dev *mp2) 


	phy_base <<= 21;

	if (!devm_request_mem_region(dev, phy_base, 128 * 1024, "amd_sfh")) {

		dev_err(dev, "can't reserve mmio registers\n");

		dev_dbg(dev, "can't reserve mmio registers\n");

		return -ENOMEM;

	}



	mp2->vsbase = devm_ioremap(dev, phy_base, 128 * 1024);

	if (!mp2->vsbase) {

		dev_err(dev, "failed to remap vsbase\n");

		dev_dbg(dev, "failed to remap vsbase\n");

		return -ENOMEM;

	}
@@ -301,7 +301,7 @@ int amd_sfh1_1_init(struct amd_mp2_dev *mp2) 


	memcpy_fromio(&binfo, mp2->vsbase, sizeof(struct sfh_base_info));

	if (binfo.sbase.fw_info.fw_ver == 0 || binfo.sbase.s_list.sl.sensors == 0) {

		dev_err(dev, "failed to get sensors\n");

		dev_dbg(dev, "failed to get sensors\n");

		return -EOPNOTSUPP;

	}

	dev_dbg(dev, "firmware version 0x%x\n", binfo.sbase.fw_info.fw_ver);