Unverified Commit be5cddef authored by Serge Semin's avatar Serge Semin Committed by Arnd Bergmann
Browse files

bus: bt1-apb: Don't print error on -EPROBE_DEFER 



The Baikal-T1 APB bus driver correctly handles the deferred probe
situation, but still pollutes the system log with a misleading error
message. Let's fix that by using the dev_err_probe() method to print the
log message in case of the clocks/resets request errors.

Signed-off-by: default avatarSerge Semin <Sergey.Semin@baikalelectronics.ru>
Link: https://lore.kernel.org/r/20220610104030.28399-1-Sergey.Semin@baikalelectronics.ru

'
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 96589042

drivers/bus/bt1-apb.c

+6 −8
Original line number Diff line number Diff line
@@ -175,10 +175,9 @@ static int bt1_apb_request_rst(struct bt1_apb *apb) 
	int ret;



	apb->prst = devm_reset_control_get_optional_exclusive(apb->dev, "prst");

	if (IS_ERR(apb->prst)) {

		dev_warn(apb->dev, "Couldn't get reset control line\n");

		return PTR_ERR(apb->prst);

	}

	if (IS_ERR(apb->prst))

		return dev_err_probe(apb->dev, PTR_ERR(apb->prst),

				     "Couldn't get reset control line\n");



	ret = reset_control_deassert(apb->prst);

	if (ret)
@@ -199,10 +198,9 @@ static int bt1_apb_request_clk(struct bt1_apb *apb) 
	int ret;



	apb->pclk = devm_clk_get(apb->dev, "pclk");

	if (IS_ERR(apb->pclk)) {

		dev_err(apb->dev, "Couldn't get APB clock descriptor\n");

		return PTR_ERR(apb->pclk);

	}

	if (IS_ERR(apb->pclk))

		return dev_err_probe(apb->dev, PTR_ERR(apb->pclk),

				     "Couldn't get APB clock descriptor\n");



	ret = clk_prepare_enable(apb->pclk);

	if (ret) {