Commit be2ada6d authored Jul 18, 2022 by Chaitanya Kulkarni Committed by Jens Axboe Aug 02, 2022

nvmet-auth: fix return value check in auth receive



nvmet_auth_challenge() return type is int and currently it uses status
variable that is of type u16 in nvmet_execute_auth_receive().

Catch the return value of nvmet_auth_challenge() into int and set the
NVME_SC_INTERNAL as status variable before we jump to error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 1040415c

drivers/nvme/target/fabrics-cmd-auth.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -484,8 +484,7 @@ void nvmet_execute_auth_receive(struct nvmet_req *req)
		ctrl->cntlid, req->sq->qid, req->sq->dhchap_step);
		switch (req->sq->dhchap_step) {
		case NVME_AUTH_DHCHAP_MESSAGE_CHALLENGE:
		status = nvmet_auth_challenge(req, d, al);
		if (status < 0) {
		if (nvmet_auth_challenge(req, d, al) < 0) {
		pr_warn("ctrl %d qid %d: challenge error (%d)\n",
		ctrl->cntlid, req->sq->qid, status);
		status = NVME_SC_INTERNAL;