Commit bdf1b5c3 authored by 蒋家盛's avatar 蒋家盛 Committed by Jakub Kicinski
Browse files

sfc: Check null pointer of rx_queue->page_ring 



Because of the possible failure of the kcalloc, it should be better to
set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
the consistency.

Fixes: 5a6681e2 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Link: https://lore.kernel.org/r/20211220135603.954944-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 99d7fbb5

drivers/net/ethernet/sfc/rx_common.c

+4 −1
Original line number Diff line number Diff line
@@ -150,6 +150,9 @@ static void efx_init_rx_recycle_ring(struct efx_rx_queue *rx_queue) 
					    efx->rx_bufs_per_page);

	rx_queue->page_ring = kcalloc(page_ring_size,

				      sizeof(*rx_queue->page_ring), GFP_KERNEL);

	if (!rx_queue->page_ring)

		rx_queue->page_ptr_mask = 0;

	else

		rx_queue->page_ptr_mask = page_ring_size - 1;

}