Commit bd8247ee authored by Ritesh Harjani's avatar Ritesh Harjani Committed by Theodore Ts'o
Browse files

ext4: no need to test for block bitmap bits in ext4_mb_mark_bb() 



We don't need the return value of mb_test_and_clear_bits() in ext4_mb_mark_bb()
So simply use mb_clear_bits() instead.

Signed-off-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/a971935306dafb124da0193c7dad1aa485210b62.1644992610.git.riteshh@linux.ibm.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 123e3016

fs/ext4/mballoc.c

+1 −1
Original line number Diff line number Diff line
@@ -3941,7 +3941,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block, 
		if (state)

			mb_set_bits(bitmap_bh->b_data, blkoff, clen);

		else

			mb_test_and_clear_bits(bitmap_bh->b_data, blkoff, clen);

			mb_clear_bits(bitmap_bh->b_data, blkoff, clen);

		if (ext4_has_group_desc_csum(sb) &&

		    (gdp->bg_flags & cpu_to_le16(EXT4_BG_BLOCK_UNINIT))) {

			gdp->bg_flags &= cpu_to_le16(~EXT4_BG_BLOCK_UNINIT);